Skip to content

update warp and other dependencies#66

Open
dwilkolek wants to merge 3 commits intodanielSanchezQ:masterfrom
dwilkolek:master
Open

update warp and other dependencies#66
dwilkolek wants to merge 3 commits intodanielSanchezQ:masterfrom
dwilkolek:master

Conversation

@dwilkolek
Copy link
Copy Markdown

No description provided.

@danielSanchezQ
Copy link
Copy Markdown
Owner

Hi @dwilkolek I missed this in the notifications, sorry for the late reply. I'm down to update it. Can we give it a more recent shot?

@dwilkolek
Copy link
Copy Markdown
Author

Sure! I can revisit the thing this weekend. I'm using the forked version as dependency since I created this PR 😉

@dwilkolek
Copy link
Copy Markdown
Author

Now it should be up to date with latest dependency versions. 😉
I've tested it on my personal project and it works.

@dwilkolek
Copy link
Copy Markdown
Author

dwilkolek commented Apr 18, 2026

One crucial details, Body::wrap_stream was removed hence I await for whole response. This might cause problems with big responses.

I managed to get streaming back with AI, but I can't tell if there are hidden issues diff . I can create a PR if you like but I can't vouch for it. It works tho 😅

@danielSanchezQ
Copy link
Copy Markdown
Owner

danielSanchezQ commented Apr 22, 2026

One crucial details, Body::wrap_stream was removed hence I await for whole response. This might cause problems with big responses.

I managed to get streaming back with AI, but I can't tell if there are hidden issues diff . I can create a PR if you like but I can't vouch for it. It works tho 😅

Is it included in this PR?
I see it is not. I would like to keep the streaming because as you said big responses may be problematic. Can you add the commit with that here? Otherwise I'll take a look at it myself (whenever I have time 😅 )

Ok, I just saw the commit, I don't like that unsafe there and I think it can be done simpler. I will update this PR with a new commit myself. Will ping you so you check on your project to see if it works as expected. wdyt?

Repository owner deleted a comment from daniel-tradeonapex Apr 22, 2026
@dwilkolek
Copy link
Copy Markdown
Author

Sounds good to me. Just ping me and I'll check it out 🙂

@danielSanchezQ
Copy link
Copy Markdown
Owner

@dwilkolek apparently there was a regresion in exposing the stream body:
seanmonstar/warp#1160

I think I'll just wait till that gets released. I actually got it working locally but I had to use an unsafe transmute to mirror the non public type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants